refactor: sh http server simplify and cleanup

1 files changed, 8 insertions, 10 deletions

diff --git a/http-server.sh b/http-server.sh
index aa5e17e..3e47a4e 100644
--- a/http-server.sh
+++ b/http-server.sh
@@ -5,8 +5,8 @@
 # Sends a greeting message and the date in the response.
 
 
-# Info: Relies on the OpenBSD version of Netcat
-#       GNU netcat may or may not work.
+# Warning: Relies on the OpenBSD version of Netcat.
+#          GNU netcat may or may not work.
 
 # Creating a FIFO so that the output of nc can be processed and used to determine the input.
 # Allows for "passing values back round"
@@ -16,25 +16,23 @@ mkfifo "$outfifo"
 
 # Run forever
 while true; do
-    x="$(date)"
-    len="$(echo "$x" | wc -c)"
-    cat "$outfifo" \
-        | nc -l localhost 1500 \
-        | while read -r line; do
+    cat "$outfifo" | \
+        nc -l localhost 1500 | \
+        while read -r line; do
             line=$(echo "$line" | tr -d '\r\n')
             echo "< $line"
 
             if echo "$line" | grep -qE '^GET /'; then
                 # on reading the request line, extract a value from the request path and build the response
-                name="$(echo $line | sed 's:GET /\([^ ]*\).*:\1:')"
+                name="$(echo "$line" | sed 's:GET /\([^ ]*\).*:\1:')"
                 content="Hello $name, the date and time is $(date)."
                 # Without Content-Length header, connection will not close properly
-                len="$(echo "$content" | wc -c)"
+                len="${#content}"
 
                 response="HTTP/1.1 200 OK\nContent-Length: $len\nContent-Type: plain/text\n\n$content"
             elif [ -z "$line" ]; then # end of request
                 # send response once all of the request has been read
-                echo -e "$response" > "$outfifo"
+                printf "%b" "$response" > "$outfifo"
             fi
         done
     done